This repository was archived by the owner on Apr 8, 2024. It is now read-only.
Add exit judgement for cgroupv1 only host #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuyaoZhong
suggested changes
Jan 10, 2023
| @@ -53,13 +53,17 @@ func getCgroupPath() (string, error) { | |||
| enabled, err := v2.Enabled() | |||
There was a problem hiding this comment.
You need to check if v2 is enabled first to determine raising error or not, and check if v1 is enabled to determine the path. Otherwise in current change, it returns "/sys/fs/cgroup" when both v1 and v2 enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lagacy system with only cgroupv1 enabled, since cgroupv2 is necessary for istio-tcpip-bypass to take effects. Program will just exit with error message for warning.